[system] Fix sx prop types when CSS variables are used with nested selectors #31163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
commented
Feb 21, 2022
| @@ -48,8 +55,7 @@ export type SystemCssProperties<Theme extends object = {}> = { | |||
| export type SystemStyleObject<Theme extends object = {}> = | |||
| | SystemCssProperties<Theme> | |||
| | CSSPseudoSelectorProps<Theme> | |||
| | CSSSelectorObject<Theme> | |||
| | { [cssVariable: string]: string | number } | |||
There was a problem hiding this comment.
[cssVariable: string] is basically the same as [cssSelector: string] defined in CSSSelectorObject, so whichever will be mapped first, will invalidate the other, hence the CSS variables cannot be defined in the same object as nested selectors (see the tests)
siriwatknp
reviewed
Feb 22, 2022
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
michaldudak
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
I had to remove two @ts-expect-errors, not ideal, but I think fixing the problem with the CSS variables used together with the nested selectors is more important.
We need to loosen the type strictness anyway, so I wouldn't worry about this much. I can't think of a solution better than you proposed.
This comment was marked as abuse.
This comment was marked as abuse.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in #31138. Basically, if the CSS variables are used together with some nested selectors in the
sxprop, it breaks the types. I've added tests and update the types, see #31163 (comment).I had to remove two @ts-expect-errors, not ideal, but I think fixing the problem with the CSS variables used together with the nested selectors is more important.