Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-fetch to ^3.3.2 - autoclosed #31603

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 13, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
node-fetch ^2.6.12 -> ^3.3.2 age adoption passing confidence

Release Notes

node-fetch/node-fetch (node-fetch)

v3.3.2

Compare Source

Bug Fixes

v3.3.1

Compare Source

Bug Fixes

v3.3.0

Compare Source

Features

v3.2.10

Compare Source

Bug Fixes

v3.2.9

Compare Source

Bug Fixes
  • Headers: don't forward secure headers on protocol change (#​1599) (e87b093)

v3.2.8

Compare Source

Bug Fixes

v3.2.7

Compare Source

Bug Fixes

v3.2.6

Compare Source

Bug Fixes

v3.2.5

Compare Source

Bug Fixes

v3.2.4

Compare Source

Bug Fixes

v3.2.3

Compare Source

Bug Fixes

v3.2.2

Compare Source

Bug Fixes

v3.2.1

Compare Source

Bug Fixes

v3.2.0

Compare Source

Features

v3.1.1

Compare Source

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.0.0...v3.1.0

v3.0.0

Compare Source

version 3 is going out of a long beta period and switches to stable

One major change is that it's now a ESM only package
See changelog for more information about all the changes.


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Mar 13, 2022
@mui-bot
Copy link

mui-bot commented Mar 13, 2022

Fails
🚫

Danger failed to run dangerfile.ts.

Error SyntaxError

Cannot use import statement outside a module
/tmp/material-ui/node_modules/node-fetch/src/index.js:9
import http from 'node:http';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Object.customModuleHandler (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:129:28)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at _module2.default._load (/tmp/material-ui/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/tmp/material-ui/scripts/sizeSnapshot/loadComparison.js:13:13)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Object.customModuleHandler (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:129:28)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at _module2.default._load (/tmp/material-ui/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/tmp/material-ui/scripts/sizeSnapshot/index.js:3:22)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Object.customModuleHandler (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:129:28)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at _module2.default._load (/tmp/material-ui/node_modules/override-require/dist/overrideRequire.js:43:25)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (dangerfile.ts:52:22)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at requireFromString (/tmp/material-ui/node_modules/require-from-string/index.js:28:4)
    at /tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:161:68
    at step (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)
    at __awaiter (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:23:12)
    at runDangerfileEnvironment (/tmp/material-ui/node_modules/danger/distribution/runner/runners/inline.js:118:132)
    at /tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:180:38
    at step (/tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:25:53)
    at /tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:19:71
    at new Promise (<anonymous>)
    at __awaiter (/tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:15:12)
    at Object.executeRuntimeEnvironment (/tmp/material-ui/node_modules/danger/distribution/platforms/GitHub.js:143:88)
    at /tmp/material-ui/node_modules/danger/distribution/commands/danger-runner.js:100:47
    at step (/tmp/material-ui/node_modules/danger/distribution/commands/danger-runner.js:34:23)
    at Object.next (/tmp/material-ui/node_modules/danger/distribution/commands/danger-runner.js:15:53)
    at fulfilled (/tmp/material-ui/node_modules/danger/distribution/commands/danger-runner.js:6:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Dangerfile

68| /**
69|  * Generates a user-readable string from a percentage change
70|  * @param {number} change
71|  * @param {string} goodEmoji emoji on reduction
72|  * @param {string} badEmoji emoji on increase
--------------------^
73|  */
74| function addPercent(change: number, goodEmoji = '', badEmoji = ':small_red_triangle:') {
75|   const formatted = (change * 100).toFixed(2);
76|   if (/^-|^0(?:\.0+)$/.test(formatted)) {

Generated by 🚫 dangerJS against 570bee9

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 14, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 246202f to 689eead Compare March 14, 2022 08:17
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 14, 2022
@renovate renovate bot changed the title Bump node-fetch to ^3.2.3 Bump node-fetch to ^3.2.4 Apr 28, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 689eead to 664c4c4 Compare April 28, 2022 11:09
@render
Copy link

render bot commented Apr 28, 2022

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 5, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 664c4c4 to 0790b48 Compare May 5, 2022 08:25
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 5, 2022
@michaldudak
Copy link
Member

michaldudak commented May 31, 2022

node-fetch is now a pure ES module. It's used in scripts/sizeSnapshots/loadComparison, which is used by the Dangerfile, which must be a CJS module. Therefore, we can't update node-fetch until Danger supports loading configuration from ES modules (danger/danger-js#1180).

@michaldudak michaldudak added the on hold There is a blocker, we need to wait label May 31, 2022
@renovate renovate bot changed the title Bump node-fetch to ^3.2.4 Bump node-fetch to ^3.2.5 Jun 1, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 0790b48 to 2944f7a Compare June 1, 2022 21:57
@renovate renovate bot changed the title Bump node-fetch to ^3.2.5 Bump node-fetch to ^3.2.6 Jun 9, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 2944f7a to 6cfa3a2 Compare June 9, 2022 14:31
@renovate renovate bot changed the title Bump node-fetch to ^3.2.6 Bump node-fetch to ^3.2.7 Jul 11, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 6cfa3a2 to 0e04d47 Compare July 11, 2022 23:14
@renovate renovate bot changed the title Bump node-fetch to ^3.2.7 Bump node-fetch to ^3.2.8 Jul 12, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 0e04d47 to d25b477 Compare July 12, 2022 17:22
@renovate renovate bot changed the title Bump node-fetch to ^3.2.8 Bump node-fetch to ^3.2.9 Jul 18, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from d25b477 to 78798f3 Compare July 18, 2022 16:33
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 26, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 78798f3 to 0f68670 Compare July 26, 2022 09:11
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 26, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 0f68670 to 0ff335a Compare July 27, 2022 07:04
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 27, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 27, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 2a6da33 to 2d3d84d Compare March 27, 2023 11:59
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 27, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 17, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 2d3d84d to f1d0c00 Compare April 17, 2023 06:43
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 17, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from f1d0c00 to a9305a0 Compare May 1, 2023 13:02
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 9, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from a9305a0 to da60dcc Compare May 9, 2023 06:03
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 9, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from da60dcc to c08cac3 Compare May 15, 2023 15:52
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 15, 2023
@michaldudak
Copy link
Member

After we migrate to node 18 (#37173), we should be able to use the native fetch function.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 3, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from f8b580d to 8808314 Compare July 3, 2023 09:16
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 3, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 8808314 to 9af16a7 Compare July 18, 2023 10:28
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@renovate renovate bot changed the title Bump node-fetch to ^3.3.1 Bump node-fetch to ^3.3.2 Jul 25, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 9af16a7 to 570bee9 Compare July 25, 2023 12:24
@renovate renovate bot changed the title Bump node-fetch to ^3.3.2 Bump node-fetch to ^3.3.2 - autoclosed Aug 1, 2023
@renovate renovate bot closed this Aug 1, 2023
@renovate renovate bot deleted the renovate/node-fetch-3.x branch August 1, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies on hold There is a blocker, we need to wait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants