[AutoComplete] Add key support for dataSource, add sort function property #3182
Conversation
mbrookes
added
the
PR: needs revision
mbrookes
changed the title
|
@yongxu Thanks for doing this. 👍 Please could you take a look at the linting errors. |
| innerDivStyle={{overflow: 'hidden'}} | ||
| value={item} | ||
| primaryText={item} | ||
| />) |
There was a problem hiding this comment.
Add a comma:/>),, and possibly put ), on its own line. (Not sure what the preferred house style is?)
yongxu
changed the title
|
@mbrookes sorry moving took longer than expected. Just got time to work on this again, now trying to fix this asap! |
added sort function prop
yongxu
force-pushed
the
ac3137
branch
3 times, most recently
from
6dc1f04 to
a7a91fc
Compare
…o yongxu/ac3137 Conflicts: src/auto-complete.jsx fixed issue mui#3137, removed key from last commit and resolved conflicts NOTE: open should not be an state, need to be fixed in the future
mbrookes
added
PR: Needs Review
and removed
PR: needs revision
yongxu
changed the title
mbrookes
added
the
PR: out-of-date
|
@yongxu - sorry this got left behind. Please could you rebase and squash, we'll get this merged before it gets more merge conflicts! |
|
@mbrookes Oops, it is my bad I forgot it too. I am going to work on this rebase |
|
Thank you @yongxu - sorry for the trouble! |
|
@mbrookes Looks like this PR is too hard to rebase. I am going to rewrite some of the changes and start another PR that includes all the updates from this one. Will finish either tonight or tomorrow :) |
|
The rewritten PR is finished, please checkout #3662 |
added key support for dataSource.
added sort function prop as well.
Closes #3137.