-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Fix TypeScript FormHelperTextProps component prop #31931
[TextField] Fix TypeScript FormHelperTextProps component prop #31931
Conversation
Thanks for this PR @igordanchenko, I came across this issue as well and it looks like multiple MUI components that support a |
@pzi, I noticed that as well. But since this is my first PR here, I decided to keep the scope limited to one ticket and see how the process goes. |
@igordanchenko I'd recommend keeping your branch up to date with upstream master to increase the chances to get this merged. Any chance of a review of this @siriwatknp, please? |
@pzi, what do you mean? I do not see any conflicts and this PR can be auto merged. |
|
@pzi, thank you for the dictionary lesson but I'm sure that's not the reason why this PR didn't get any traction. |
@igordanchenko apologies if it came across that way, I was just hoping that this could be reviewed and merged soon by someone @ MUI. |
2 months was more than enough time to triage this PR, so obviously there wasn’t enough appetite to get #20360 fixed. I was actually about to drop this PR anyway. |
I'd like to revive the dormant PR #20529
Closes #20360