Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Fix TypeScript FormHelperTextProps component prop #31931

Closed
wants to merge 1 commit into from
Closed

[TextField] Fix TypeScript FormHelperTextProps component prop #31931

wants to merge 1 commit into from

Conversation

igordanchenko
Copy link
Contributor

I'd like to revive the dormant PR #20529

Closes #20360

@mui-bot
Copy link

mui-bot commented Mar 21, 2022

No bundle size changes

Generated by 🚫 dangerJS against 07dcd0c

@igordanchenko igordanchenko marked this pull request as ready for review March 21, 2022 20:48
@danilo-leal danilo-leal added the component: text field This is the name of the generic UI component, not the React module! label Mar 21, 2022
@pzi
Copy link
Contributor

pzi commented Mar 23, 2022

Thanks for this PR @igordanchenko, I came across this issue as well and it looks like multiple MUI components that support a component prop have the same TypeScript issue. e.g. Paper

@igordanchenko
Copy link
Contributor Author

@pzi, I noticed that as well. But since this is my first PR here, I decided to keep the scope limited to one ticket and see how the process goes.

@pzi
Copy link
Contributor

pzi commented Mar 25, 2022

@pzi, I noticed that as well. But since this is my first PR here, I decided to keep the scope limited to one ticket and see how the process goes.

Yeah fair enough :) I'd do the same (and did in my open PR #31398)

@pzi
Copy link
Contributor

pzi commented May 16, 2022

@igordanchenko I'd recommend keeping your branch up to date with upstream master to increase the chances to get this merged.

Any chance of a review of this @siriwatknp, please?

@igordanchenko
Copy link
Contributor Author

@pzi, what do you mean? I do not see any conflicts and this PR can be auto merged.

@pzi
Copy link
Contributor

pzi commented May 16, 2022

@igordanchenko
Copy link
Contributor Author

@pzi, thank you for the dictionary lesson but I'm sure that's not the reason why this PR didn't get any traction.

@pzi
Copy link
Contributor

pzi commented May 16, 2022

@igordanchenko apologies if it came across that way, I was just hoping that this could be reviewed and merged soon by someone @ MUI.

@igordanchenko
Copy link
Contributor Author

2 months was more than enough time to triage this PR, so obviously there wasn’t enough appetite to get #20360 fixed. I was actually about to drop this PR anyway.

@igordanchenko igordanchenko deleted the textfield/form-helper-text-props branch May 16, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing the component type on FormHelperText.d.ts
4 participants