Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base] Add @mui/types to dependencies #31951

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[base] Add @mui/types to dependencies #31951

merged 1 commit into from
Mar 23, 2022

Conversation

bicstone
Copy link
Contributor

@bicstone bicstone commented Mar 22, 2022 •
edited
Loading

Currently, @mui/types is set to devDependencies.
If @mui/base is used by itself in a typescript project, type resolution will not work.

material-ui/packages/mui-base/src/FormControlUnstyled/FormControlUnstyled.tsx

Line 4 in 1470c72

import { OverridableComponent } from '@mui/types';

This PR added @mui/types to dependencies like other packages.

@bicstone bicstone changed the title [base] add @mui/types to dependencies [base] Add @mui/types to dependencies Mar 22, 2022
@mui-bot
Copy link

mui-bot commented Mar 22, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 535a97e

@bicstone bicstone changed the title [base] Add @mui/types to dependencies [base] Add @mui/types to dependencies Mar 22, 2022
@danilo-leal danilo-leal added the package: base-ui Specific to @mui/base label Mar 23, 2022
mnajdova
mnajdova approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova merged commit 6cbaca7 into mui:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bicstone @mui-bot @mnajdova @danilo-leal