Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Fix variant prop placement #31990

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

ryancogswell
Copy link
Contributor

A spread of props onto an element could contain a variant. If so, that should win over the variant added by the codemod, so adding the codemod variant to the beginning of the props rather than the end.

A spread of props onto an element could contain a variant. If so, that should win over the variant added by the codemod so adding the codemod variant to the beginning of the props rather than the end.
@ryancogswell
Copy link
Contributor Author

Just a little issue I noticed while browsing through codemods looking for examples of things I need to do in the jss to tss-react codemod.

@mui-bot
Copy link

mui-bot commented Mar 26, 2022

No bundle size changes

Generated by 🚫 dangerJS against 075fc4b

@danilo-leal danilo-leal added the package: codemod Specific to @mui/codemod label Mar 26, 2022
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mnajdova mnajdova merged commit 9ff2330 into mui:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: codemod Specific to @mui/codemod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants