Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve icon synonyms #32742

Merged
merged 3 commits into from
May 31, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 11, 2022

Initially, I wanted to fix the search results of the query +. I couldn't make it happen. Instead, I have run docs:mdicons:synonyms but I had to clean up the output. This script is not perfect.

Before

http://0.0.0.0:3000/material-ui/material-icons/

Screenshot 2022-05-12 at 01 58 24

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: icons Specific to @mui/icons labels May 11, 2022
@mui-bot
Copy link

mui-bot commented May 12, 2022

No bundle size changes

Generated by 🚫 dangerJS against dd9f0ae

@michaldudak
Copy link
Member

It seems there's still something wrong with the script - I'm getting the following error on /material-ui/material-icons:

image

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 24, 2022

@michaldudak I have noticed the same. We have the same issue when running the script from HEAD. Let's say this PR is already a step forward, even if it's not going all the way 😁

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 31, 2022

I believe that the change is safe. Running the script now generates less noise than before, but there are still some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants