Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Throw on 301 links #32939

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 28, 2022

The goal of this PR is to make it so that contributors get fast feedback look when not writing correct links, it should avoid a number of the issues in #32851 to happen in the first place. This is required because of:

trailingSlash: true,

The error looks like this now:

Screenshot 2022-05-29 at 01 56 02

For context, SEO is a competitive advantage, AFAIK, quality links encourage Google to rank us higher.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 28, 2022
@mui-bot
Copy link

mui-bot commented May 28, 2022

No bundle size changes

Generated by 🚫 dangerJS against b321274

@oliviertassinari oliviertassinari marked this pull request as ready for review May 28, 2022 23:27
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label May 28, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 30, 2022
@oliviertassinari oliviertassinari requested a review from a team May 30, 2022 22:34
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 30, 2022
@oliviertassinari oliviertassinari merged commit 0fa01ac into mui:master Jun 3, 2022
@oliviertassinari oliviertassinari deleted the fail-301-links branch June 3, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants