-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove pickers page from the Lab section #32961
[docs] Remove pickers page from the Lab section #32961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a 301 redirection to the X doc or leave it fails with a 404 ?
A redirect would be nicer. I'll add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections, sounds fair 👍. If I were to challenge it, I would raise:
The reason is that it can be confusing for new pickers users to know which page to look at (there are 2 in the search)
I think that the main advantage of this page https://mui.com/material-ui/lab-date-and-time-pickers/ is for developers that are used to finding the component using the navigation:
For them, we could have solved the problem by removing the page from the search indexes (Google & Algolia). Now, these developers can still search and they will find the new location of the component, so I think that we are good.
Depends on #32950
I think that we could merge the two independently. I don't see a direct need for one to be merged with the other.
I'm merging it be sure not to forget it on Monday's release |
Depends on #32950
As part of the effort started in #32950 we would also want to remove the pickers page that is under the Lab section. The reason is that it can be confusing for new pickers users to know which page to look at (there are 2 in the search). By removing it will be clear that the correct package to use is the one under
@mui-x
.https://deploy-preview-32961--material-ui.netlify.app/material-ui/about-the-lab/