Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove pickers page from the Lab section #32961

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented May 31, 2022

Depends on #32950

As part of the effort started in #32950 we would also want to remove the pickers page that is under the Lab section. The reason is that it can be confusing for new pickers users to know which page to look at (there are 2 in the search). By removing it will be clear that the correct package to use is the one under @mui-x.

https://deploy-preview-32961--material-ui.netlify.app/material-ui/about-the-lab/

@DanailH DanailH added the docs Improvements or additions to the documentation label May 31, 2022
@DanailH DanailH self-assigned this May 31, 2022
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a 301 redirection to the X doc or leave it fails with a 404 ?

@DanailH
Copy link
Member Author

DanailH commented May 31, 2022

Should we add a 301 redirection to the X doc or leave it fails with a 404?

A redirect would be nicer. I'll add it.

@mui-bot
Copy link

mui-bot commented May 31, 2022

No bundle size changes

Generated by 🚫 dangerJS against 4bbed0c

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, sounds fair 👍. If I were to challenge it, I would raise:

The reason is that it can be confusing for new pickers users to know which page to look at (there are 2 in the search)

I think that the main advantage of this page https://mui.com/material-ui/lab-date-and-time-pickers/ is for developers that are used to finding the component using the navigation:

Screenshot 2022-05-31 at 17 09 41

For them, we could have solved the problem by removing the page from the search indexes (Google & Algolia). Now, these developers can still search and they will find the new location of the component, so I think that we are good.

Depends on #32950

I think that we could merge the two independently. I don't see a direct need for one to be merged with the other.

@flaviendelangle
Copy link
Member

I'm merging it be sure not to forget it on Monday's release

@flaviendelangle flaviendelangle merged commit 6f90d58 into mui:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants