Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix icon color in BadgeUnstyled docs #32976

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jun 1, 2022

The Mail icon is almost not visible in dark mode in the Base's Badge component docs.
The color style is not needed because of which the SVG picks it up and applies in it's fill: currentColor property.

Check the docs in both the modes:
Before: https://mui.com/base/react-badge/
Now: https://deploy-preview-32976--material-ui.netlify.app/base/react-badge/

If it looks good, I will approve the argos CI since there is difference in light mode (now it's just a bit darker rgba(0, 0, 0, 0.7) -> rgb(0, 0, 0)).

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: badge This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jun 1, 2022
@mui-bot
Copy link

mui-bot commented Jun 1, 2022

No bundle size changes

Generated by 🚫 dangerJS against 8af7dc5

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review June 1, 2022 10:55
@michaldudak michaldudak requested a review from danilo-leal June 1, 2022 19:13
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👌

@ZeeshanTamboli ZeeshanTamboli merged commit 5d04d34 into mui:master Jun 2, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the docs-BadgeUnstyled-MailIcon-color branch June 2, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants