[Popover] Remove window-listenable mixin #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| useLayerForClickAway={this.props.useLayerForClickAway} | ||
| render={this.renderLayer} | ||
| /> | ||
| <noscript> |
There was a problem hiding this comment.
Let me know what you think about this, the children component both return null, I wasn't sure what the right tag was to use for something that ultimately wasn't rendering anything. I settled for noscript (which is what I think React uses when you return null) but if you'd prefer div or something else let me know.
9 tasks
|
Good good to me 👍 |
|
Could you remove this too? windowListeners: {
resize: 'setPlacementThrottled',
scroll: 'setPlacementThrottledScrolled',
}, |
oliviertassinari
added
PR: needs revision
|
Thanks good catch, I thought I did. |
|
Done! |
newoga
force-pushed
the
#3305/popover
branch
from
e0a2c7c to
a32da08
Compare
newoga
added
PR: Needs Review
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Feb 12, 2016
[Popover] Remove window-listenable mixin
|
@newoga Thanks 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.