[DatePicker] Remove window-listenable mixin #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Yeah I think we should remove that method. I don't get it either O.o Thanks 👍 |
oliviertassinari
added a commit
that referenced
this pull request
Feb 14, 2016
[DatePicker] Remove window-listenable mixin
|
@newoga Thanks! Should we deprecate the |
|
@oliviertassinari Let's remove it. it wasn't documented. I'd say lets remove all mixins from the library for the 0.15.0 release. We'll call it the |
Alright, 💥. |
|
Yeeeaaah 👊 💥 💣 |
zannager
added
component: date picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last set of components for #3305.
Take note of the
date-picker.jsxcomponent. It had the mixin tied into an unimplemented method. I just removed them for now, but if you think we should implement it now, I can add the EventListener and take a stab. I'm not sure if I quite understand what it was trying to accomplish though.