Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add notification to aggregation blogpost #33745

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Aug 1, 2022

Summary

Add notification linking to blogpost: https://master--material-ui.netlify.app/blog/aggregation-functions/

Important: To merge after this week's release.

@joserodolfofreitas joserodolfofreitas added docs Improvements or additions to the documentation blog MUI X labels Aug 1, 2022
@joserodolfofreitas joserodolfofreitas changed the title Add notification to aggregation blogpost [docs] Add notification to aggregation blogpost Aug 1, 2022
@mui-bot
Copy link

mui-bot commented Aug 1, 2022

No bundle size changes

Generated by 🚫 dangerJS against 17abc07

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the older notifications? It's a bit overwhelming:

Screenshot 2022-08-01 at 22 41 00

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Congrat on the aggregation feature!

@joserodolfofreitas joserodolfofreitas merged commit 4ced48e into mui:master Aug 2, 2022
"userLanguage": "zh"
},
{
"id": 53,
Copy link
Member

@oliviertassinari oliviertassinari Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this one and the previous one were meant it be ever green notifications. The first one is only shown to Chinese users. The second one correlates with x2 more followers the last time we tried to measure the impact #20337

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
* Add notification to aggregation blogpost
* Remove old notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog docs Improvements or additions to the documentation MUI X
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants