-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add Toolpad to Navigation #33937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We are missing
/static/branding/product-toolpad-light.svg
- In [website] Landing page toolpad#809 we say that this PR should be merged first. Are we sure? I would expect a link to only be added once the page it links to is present.
{ | ||
name: 'MUI Toolpad', | ||
description: 'Low-code tool builder, powered by MUI.', | ||
href: ROUTES.toolpadDocs, | ||
chip: 'Alpha', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the docs of Toolpad is mature enough to be linked 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion is that we can include the Docs link later
I have pushed a change so that the new sections in the docs are only visible in staging ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, no more feedback on my end, I think that we can merge as soon as we get an approved review. I like how we are doing a couple of clean-ups at the same time :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving to not increase the review pressure on the core team.
Once mui/toolpad#809 is merged, I think that we can remove the process.env.STAGING
checks.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
It's part of this effort: mui/toolpad#809
Preview https://deploy-preview-33937--material-ui.netlify.app/.