[SvgIcon] Fix passing an ownerState to SvgIcon changes the font size #34429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
commented
Sep 22, 2022
Comment on lines
+20
to
+21
| /** Styles applied to the root element if `fontSize="medium"`. */ | ||
| fontSizeMedium: string; |
There was a problem hiding this comment.
Not related to the issue, but found this class was missing in types.
ZeeshanTamboli
commented
Sep 22, 2022
| @@ -47,7 +47,7 @@ const SvgIconRoot = styled('svg', { | |||
| inherit: 'inherit', | |||
| small: theme.typography?.pxToRem?.(20) || '1.25rem', | |||
| medium: theme.typography?.pxToRem?.(24) || '1.5rem', | |||
| large: theme.typography?.pxToRem?.(35) || '2.1875', | |||
| large: theme.typography?.pxToRem?.(35) || '2.1875rem', | |||
There was a problem hiding this comment.
rem unit was missing, not related to the issue.
ZeeshanTamboli
requested review from
siriwatknp and
michaldudak
as code owners
ZeeshanTamboli
changed the title
ownerState as a prop shouldn't affect internal ownerState
siriwatknp
reviewed
Sep 23, 2022
| this.skip(); | ||
| } | ||
|
|
||
| const { container } = render(<SvgIcon ownerState={{ fontSize: 'sm' }}>{path}</SvgIcon>); |
There was a problem hiding this comment.
Is there a real use case to test this one? I ask this because I plan to change the test file to .tsx and I am pretty sure that the SvgIcon does not support ownerState prop.
There was a problem hiding this comment.
Yes, the icon slot in MUI X Pickers does pass ownerState for CSS customization based on ownerState. Also, you can see it in the before and after CodeSandboxes in the description, so we need it.
You can use // @ts-expect-error comment.
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34056
When a custom SVG icon is provided in components slot and the slot's
componentsPropsis defined with theuseSlotPropshook, it should not override theownerStateof the internal SvgIcon.The
styledAPI does prevent forwardingownerStateof the hook, but if customizing components by other methods, the ownerState passed to the hook overrides the internal one of the SVG Icon.Even if custom icon component is not provided, the
ownerStatepassed to the hook is causing changes in the svgicon default styling.Before: https://codesandbox.io/s/data-grid-community-forked-5hnr7p?file=/src/App.tsx
After: https://codesandbox.io/s/data-grid-community-forked-p1d7rr