-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoSsr] Convert code to TypeScript #34735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbayucot
force-pushed
the
convert-nossr-typescript
branch
3 times, most recently
from
October 12, 2022 13:42
3f0b8ed
to
9e6e1f7
Compare
mbayucot
force-pushed
the
convert-nossr-typescript
branch
from
October 12, 2022 13:52
9e6e1f7
to
c533cdc
Compare
michaldudak
reviewed
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Found just one minor issue. It's OK besides that.
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Michael John Bayucot <mbayucot@gmail.com>
Got it, thanks |
michaldudak
approved these changes
Oct 13, 2022
It's a great first pull request! Thanks for your contribution! |
@michaldudak Thank you, I appreciate it :) |
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
Signed-off-by: Michael John Bayucot <mbayucot@gmail.com> Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Michael John Bayucot <mbayucot@gmail.com> Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Michael John Bayucot <mbayucot@gmail.com> Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34717