Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Migrate X page to use CSS theme variables #34922

Merged
merged 25 commits into from
Dec 12, 2022
Merged

[website] Migrate X page to use CSS theme variables #34922

merged 25 commits into from
Dec 12, 2022

Conversation

jesrodri
Copy link
Contributor

@jesrodri jesrodri commented Oct 28, 2022 •
edited by siriwatknp
Loading

@jesrodri
Copy link
Contributor Author

I'm not sure of how to deal with XComponents.

It uses mode in a different way and I wasn't able to figure out how to apply theme variables in this case yet.

Feel free to commit anything or suggest solutions!

@siriwatknp @EduardoSCosta @trizotti

@mui-bot
Copy link

mui-bot commented Oct 28, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-34922--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d1aa8ad

@zannager zannager added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. website Pages that are not documentation-related, marketing-focused. labels Oct 31, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@siriwatknp siriwatknp mentioned this pull request Oct 31, 2022
Closed
10 tasks
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 1, 2022
@siriwatknp siriwatknp mentioned this pull request Nov 1, 2022
Merged
1 task
@siriwatknp
Copy link
Member

@jesrodri Thanks a lot for your contribution!

I put on hold label because we have to update the date-pickers and maybe the data-grid to support CSS theme variables first.

@siriwatknp siriwatknp added the on hold There is a blocker, we need to wait label Nov 1, 2022
@siriwatknp siriwatknp mentioned this pull request Nov 1, 2022
Closed
2 tasks
@siriwatknp siriwatknp marked this pull request as ready for review December 6, 2022 05:02
@siriwatknp siriwatknp self-requested a review December 6, 2022 05:02
@siriwatknp siriwatknp removed the on hold There is a blocker, we need to wait label Dec 6, 2022
@siriwatknp
Copy link
Member

Updated the DataGrid and DatePicker to the latest. This PR is ready for review.

@siriwatknp siriwatknp removed the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Dec 6, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 9, 2022
siriwatknp
siriwatknp approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

@siriwatknp
Copy link
Member

cc @mnajdova @oliviertassinari This PR updates the DataGrid and DatePickers to v6-alpha to get the CSS vars support.

@michaldudak michaldudak merged commit 4ae4c5f into mui:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jesrodri @mui-bot @siriwatknp @michaldudak @zannager