Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Migrate internal docs-utilities package to TypeScript #35846

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[core] Migrate internal docs-utilities package to TypeScript #35846

merged 3 commits into from
Jan 18, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jan 17, 2023 •
edited
Loading

It was throwing the following error:

A parameter initializer is only allowed in a function or constructor implementation.

Edit: I migrated the docs-utilities to TypeScript instead.

@ZeeshanTamboli ZeeshanTamboli added core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product labels Jan 17, 2023
@mui-bot
Copy link

mui-bot commented Jan 17, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35846--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 406a0de

@ZeeshanTamboli ZeeshanTamboli changed the title [core] Fix type definition of getUnstyledFilename method [core] Migrate internal docs-utilities package to TypeScript Jan 18, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit f13e534 into mui:master Jan 18, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the fix-type-definition-of-getUnstyledFilename branch January 18, 2023 10:09
@michaldudak
Copy link
Member

This package was left in JS on purpose. See the discussion with @Janpot: #35244 (comment)

@ZeeshanTamboli
Copy link
Member Author

This package was left in JS on purpose. See the discussion with @Janpot: #35244 (comment)

@michaldudak Oh! I didn't know about that. My main goal in this PR was to fix the incorrect syntax (d67726c), but I later migrated it to TypeScript as it seemed a better way. My recommendation is to leave it as is for the time being, and if it causes an issue as discussed, then roll back to JS +.d.ts later. It is small. What do you think? If otherwise, I can revert and only keep the fix.

@michaldudak
Copy link
Member

Let's keep just the fix please.

ZeeshanTamboli added a commit to ZeeshanTamboli/material-ui that referenced this pull request Jan 20, 2023
@ZeeshanTamboli
Revert "[core] Migrate internal docs-utilities package to TypeScript (
06136db 
mui#35846)"

This reverts commit f13e534.
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jan 20, 2023
Merged
1 task
@ZeeshanTamboli
Copy link
Member Author

@michaldudak PR created - #35881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeeshanTamboli @mui-bot @michaldudak @flaviendelangle