-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix 100+ typos throughout the Material UI docs #36194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Wow, this is nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you @Lioness100 !! I can't find any problems or mistakes here.
I just resolved the merge conflicts. I suspect that they will keep popping up frequently, so we should merge this sooner rather than later.
Maybe someone else from @mui/core can confirm that nothing is broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, this is awesome! We may want to do some triple-checking though just to make sure nothing has been broken because of this... but it seems alright!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great PR!
Merge conflict markers slipped through, though and need to be corrected before this is merged.
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed super in-depth all the 145 files 😬 but overall looks really good!
I don't know why the |
@samuelsycamore I reran the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, thanks!
Thanks again @Lioness100! This was super helpful. Please feel free to open another PR like this for https://github.com/mui/mui-x and/or https://github.com/mui/mui-toolpad if you want to, and tag me for a review! 🙏 |
Glad I could help! I'll see what I can do for the other repos :) |
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
This PR fixes some typos throughout the repository (this was a trial run for a CLI I made). I know this goes against the suggestion of creating multiple small PRs instead of one big one, since this obviously modifies a lot of code in many different files, so let me know if you want me to split this into multiple PRs. I'm for the most part unfamiliar with this codebase, so tell me if anything needs to be reverted! :) thanks.
Some notes:
ThemeModeToggle.tsx
, but I'm not sure if that upholds the intent of the sentence, or if there was a typo to begin with.table.md
, but am again not sure if that was correct