[core] Enforce namespace import for ReactDOM #36208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
commented
Feb 15, 2023
.eslintrc.js
Outdated
| { | ||
| message: | ||
| "Do not import default from ReactDOM. Use a namespace import (import * as ReactDOM from 'react-dom';) instead.", | ||
| selector: 'ImportDeclaration[source.value="react-dom"] ImportDefaultSpecifier', |
There was a problem hiding this comment.
selector: 'ImportDeclaration[source.value=/^react-dom(\\u002F(server|client))?$/] ImportDefaultSpecifier' – this could work with only one additional entry using a regex but its clearer to separate out all the error messages
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
core/react-dom-import
branch
from
12edb1f
to
14845dd
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
reviewed
Feb 15, 2023
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import { createPortal } from 'react-dom'; | |||
There was a problem hiding this comment.
I'd replace lines like this one with a namespace import as well to be consistent.
There was a problem hiding this comment.
Ah I missed these kinds of imports, let me see if eslint can find them too
mj12albert
force-pushed
the
core/react-dom-import
branch
from
14845dd
to
88c3d1c
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
core/react-dom-import
branch
from
b823dc5
to
6ebf94e
Compare
github-actions
bot
removed
the
PR: out-of-date
| import { createContext } from 'react'; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
This case is interesting. I think that the initial problem was that:
import ReactDOMServer from 'react-dom/server';is wrong because React plans to no longer export default facebook/react#18102.
This change goes after something else but why not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36198
This PR updates the eslint
no-restricted-syntaxrule to enforceimport * as ReactDOM(react-dom,react-dom/client,react-dom/server) and give an error for:import ReactDOM from 'react-dom')import { createPortal } from 'react-dom')Example lint step: https://app.circleci.com/pipelines/github/mui/material-ui/91534/workflows/63fb99e1-8ccd-4c53-9106-401ead3f8c2d/jobs/485842/parallel-runs/0/steps/0-108