[Autocomplete] Provide prop to disable option equal to value warning #36275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36275--material-ui.netlify.app/ Bundle size report |
zannager
added
the
component: autocomplete
github-actions
bot
added
the
PR: out-of-date
grzegorz-jazurek
force-pushed
the
bugfix/disable-option-equal-to-value-warning
branch
from
689e351
to
57d0a02
Compare
github-actions
bot
removed
the
PR: out-of-date
|
@michaldudak I update the branch to resolve conflicts |
ZeeshanTamboli
changed the title
There was a problem hiding this comment.
My concern with having this prop is that developers may misuse it where it is expected to fix the code based on the warning.
cc @michaldudak
ZeeshanTamboli
added
bug 🐛
github-actions
bot
added
the
PR: out-of-date
|
Is there any chance of resurrecting this MR? I find myself in a similar situation to many of the comments on #29727. @ZeeshanTamboli could you explain a scenario you're thinking of, I might just be missing something, but I see valid cases for disabling this warning. |
|
See #29727 (comment) |
|
I will close this as we have decided to remove the warning #29727 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains:
disableOptionEqualToValueWarningwhich is false by default