[examples] Refactor to have better types in the Next.js + TypeScript examples #36355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
force-pushed
the
refactor/nextjs-ts-example-types
branch
from
9bb53d1 to
859d67c
Compare
Netlify deploy previewhttps://deploy-preview-36355--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
…ple to match the `material-next-ts` example
erikian
force-pushed
the
refactor/nextjs-ts-example-types
branch
from
85f75e5 to
1b6f1c9
Compare
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
@erikian It's a great first pull request on MUI 👌 Thank you for working on it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor typing changes in this example:
anyas the type for theAppcomponent just so we don't get an error when using theemotionCacheprop, we define a new component with the right props (the props from Next.js'AppTypecomponent, plus ourMyAppPropsdefined in the_app.tsxfile)EmotionJSX.Elementtype is just an alias forJSX.Element, so I think we can avoid this import here