Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Render children before MenuElementRight #3661

Closed
wants to merge 1 commit into from
Closed

[AppBar] Render children before MenuElementRight #3661

wants to merge 1 commit into from

Conversation

halayli
Copy link

@halayli halayli commented Mar 11, 2016

{children} should render before {menuElementRight}

@oliviertassinari oliviertassinari changed the title Render children before MenuElementRight [AppBar] Render children before MenuElementRight Mar 12, 2016
@oliviertassinari
Copy link
Member

You are not the only one who suggest this PR #3004.
But, having the children as the last node have advantages #3005.
Could you explain your use case?

@halayli
Copy link
Author

halayli commented Mar 14, 2016

On the left side, I wanted a < logo > < tabs > and on the right I wanted a < IconMenu >. In its current form, the < tabs > comes after < IconMenu > on the right.

Maybe add a flag to control the order?

@oliviertassinari
Copy link
Member

You raise a very good issue. This component needs to be more customizable.
Hopefully, #773 will be fixed at some point.

Maybe add a flag to control the order?

I'm not sure that we should follow this direction. I would rather work on breaking this component into smaller bites.

@halayli
Copy link
Author

halayli commented Mar 14, 2016

Agreed. I like the suggestions in #773.

@mbrookes
Copy link
Member

Agreed. I like the suggestions in #773.

Closing in favour of composability.

@mbrookes mbrookes closed this Mar 23, 2016
@zannager zannager added the component: app bar This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants