[Tabs] Improve useTab() API page #36725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Netlify deploy previewhttps://deploy-preview-36725--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-use-tab-API-page
branch
from
d3f8c4f to
b27c9e6
Compare
| */ | ||
| value?: number | string; | ||
| /** | ||
| * Callback invoked when new value is being set. | ||
| */ | ||
| onChange?: (event: React.SyntheticEvent, value: number | string) => void; | ||
| onClick?: React.MouseEventHandler; | ||
| /** | ||
| * If `true`, the component is disabled. | ||
| * @default false |
There was a problem hiding this comment.
This is inherited from useButton().
material-ui/packages/mui-base/src/useButton/useButton.types.ts
Lines 21 to 26 in b27c9e6
Ideally, we would document hooks inheritance, but in the meantime, we can continue to duplicate.
oliviertassinari
force-pushed
the
fix-use-tab-API-page
branch
from
b27c9e6 to
ca8c506
Compare
| @@ -3,14 +3,18 @@ import { UseButtonRootSlotProps } from '../useButton'; | |||
|
|
|||
| export interface UseTabParameters { | |||
| /** | |||
| * You can provide your own value. Otherwise, we fall back to the child position index. | |||
| * You can provide your own value. Otherwise, it falls back to the child position index. | |||
There was a problem hiding this comment.
There is no we in this context https://www.notion.so/mui-org/Values-2817854949c84ec2bf32b3d175564655?pvs=4#02ed36d3767942a19a6d6954a4f62487.
mnajdova
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #36715