[TextField] Add shouldComponentUpdate function #3673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3394.
edit: FYI, this change is somewhat of a band-aid since it does not address the root cause in TextField. However, this is a non-breaking change and the upcoming refactor will remove much of the internal state from the core component anyways. This gets the fix in without needing that rework right now.
Right now, when a
TextField
is controlled from outside of a portal (for eg, from outside of aDialog
), typing will prevent a double render that happens due to the internalsetState
call and some weirdness related tosetState
execution with components added through theReactDOM
API (render
,unstable_renderSubtreeIntoContainer
).However, that internal
setState
call does not change any props, state, or context. So it is breaking IME composition for no reason. This addition prevents that rerender so the component retains the IME composition event in progress.