-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Add shouldComponentUpdate function #3673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omposition breaking in portals due to a double render
@nathanmarks Don't bother with the test, this is a temporary fix, thanks a lot for getting it done 👍 👍 @callemall/material-ui Guys take a look |
That looks good to me 👍. |
alitaheri
added a commit
that referenced
this pull request
Mar 13, 2016
[TextField] Add shouldComponentUpdate function
This was referenced Aug 19, 2021
This was referenced Sep 12, 2021
zannager
added
core
Infrastructure work going on behind the scenes
component: text field
This is the name of the generic UI component, not the React module!
and removed
core
Infrastructure work going on behind the scenes
labels
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3394.
edit: FYI, this change is somewhat of a band-aid since it does not address the root cause in TextField. However, this is a non-breaking change and the upcoming refactor will remove much of the internal state from the core component anyways. This gets the fix in without needing that rework right now.
Right now, when a
TextField
is controlled from outside of a portal (for eg, from outside of aDialog
), typing will prevent a double render that happens due to the internalsetState
call and some weirdness related tosetState
execution with components added through theReactDOM
API (render
,unstable_renderSubtreeIntoContainer
).However, that internal
setState
call does not change any props, state, or context. So it is breaking IME composition for no reason. This addition prevents that rerender so the component retains the IME composition event in progress.