[docs] Fix base API redirects #36833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-36833--material-ui.netlify.app/ Bundle size report |
mnajdova
commented
Apr 10, 2023
| /api/input-unstyled/ /base/api/input-unstyled/ 301 | ||
| /pt/api/input-unstyled/ /pt/base/api/input-unstyled/ 301 | ||
| /zh/api/input-unstyled/ /zh/base/api/input-unstyled/ 301 | ||
| /api/input-unstyled/ /base/react-input/components-api/#input-unstyled 301 |
There was a problem hiding this comment.
To avoid double redirects.
mnajdova
commented
Apr 10, 2023
| /pt/api/modal-unstyled/ /pt/base/api/modal-unstyled/ 301 | ||
| /zh/api/modal-unstyled/ /zh/base/api/modal-unstyled/ 301 | ||
| /api/option-group-unstyled/ /base/api/option-group-unstyled/ 301 | ||
| /:lang/api/option-group-unstyled/ /:lang/base/api/option-group-unstyled/ 301 |
There was a problem hiding this comment.
Using /:lang/ also matches urls starting with /base/, which causes links like: https://mui.com/base/api/tabs-list-unstyled/ to be broken.
|
@oliviertassinari is there a way of testing the new redirects on pull requests? |
siriwatknp
approved these changes
Apr 11, 2023
@mnajdova with Netlify preview. |
Merged
|
I found a few more double redirections searching for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35938 (comment)