Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add Central Myanmar (my-MY), Malay (ms-MS), Nepali (ne-NP), Tagalog (tl-TL) locales #37017

Merged
merged 3 commits into from
May 16, 2023
Merged

[l10n] Add Central Myanmar (my-MY), Malay (ms-MS), Nepali (ne-NP), Tagalog (tl-TL) locales #37017

merged 3 commits into from
May 16, 2023

Conversation

cccEric
Copy link
Contributor

@cccEric cccEric commented Apr 25, 2023 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Apr 25, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against b38def1

@cccEric cccEric closed this Apr 25, 2023
@cccEric cccEric reopened this Apr 25, 2023
@cccEric cccEric closed this Apr 25, 2023
@cccEric cccEric reopened this Apr 25, 2023
@cccEric
Copy link
Contributor Author

cccEric commented Apr 25, 2023 •
edited
Loading

I am terribly sorry for the number of commits, it's my first time contributing.
Check if PR has label / test-label-applied (pull_request) is a problem , I want to know why, can you help me?

@zannager zannager added the l10n localization label Apr 25, 2023
@zannager zannager requested a review from michaldudak April 25, 2023 14:28
michaldudak
michaldudak reviewed Apr 27, 2023
View reviewed changes
packages/mui-material/src/locale/index.ts Outdated
defaultProps: {
getLabelText: (value) => {
const lastDigit = value % 10;
return `${value} तारा${lastDigit === 1 ? 's' : ''}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double-check if this is correct? I have no clue about Nepali language but it's weird to see an "s" among letters of its native alphabet.

Copy link
Contributor Author

@cccEric cccEric Apr 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I made a mistake, the correct letter should be like this स. I updated this character.

@michaldudak michaldudak changed the title [l10n] Add Central Myanmar (my-MY)、Malay (ms-MS)、Nepali (ne-NP)、 Taga… [l10n] Add Central Myanmar (my-MY), Malay (ms-MS), Nepali (ne-NP), Tagalog (tl-TL) locales Apr 27, 2023
@cccEric cccEric requested a review from michaldudak May 4, 2023 07:44
michaldudak
michaldudak approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

siriwatknp
siriwatknp approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

@siriwatknp siriwatknp merged commit 395cec2 into mui:master May 16, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@cccEric @binh1298
[l10n] Add Central Myanmar (my-MY), Malay (ms-MS), Nepali (ne-NP), Ta…
9468eeb 
…galog (tl-TL) locales (mui#37017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cccEric @mui-bot @michaldudak @siriwatknp @zannager