Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Add analyticsTags to Algolia #37600

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[docs-infra] Add analyticsTags to Algolia #37600

merged 1 commit into from
Jun 19, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 15, 2023 •
edited by oliviertassinari
Loading

Add analyticsTags to enable filtering Algolia analytics by product. One of #16502.

@Janpot Janpot added the docs Improvements or additions to the documentation label Jun 15, 2023
@Janpot Janpot marked this pull request as ready for review June 15, 2023 16:58
@mui-bot
Copy link

mui-bot commented Jun 15, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37600--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e858e73

@Janpot Janpot requested a review from oliviertassinari June 16, 2023 03:40
@Janpot Janpot mentioned this pull request Jun 16, 2023
Merged
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Jun 17, 2023
@oliviertassinari oliviertassinari changed the title [docs] Add analyticsTags to Algolia [docs-infra] Add analyticsTags to Algolia Jun 17, 2023
@oliviertassinari oliviertassinari mentioned this pull request Jun 17, 2023
Open
18 tasks
oliviertassinari
oliviertassinari reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, the data is sent:

Screenshot 2023-06-17 at 21 44 52

and then available in the UI:

Screenshot 2023-06-17 at 21 48 09

For MUI X, it will report with x-data-grid and x-date-pickers for the "product", I guess it's OK.

alexfauquette
alexfauquette approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to discover how algolia is added into the docs :)

@Janpot Janpot merged commit 0e56ecc into mui:master Jun 19, 2023
@Janpot Janpot deleted the analytics-tags branch June 19, 2023 07:58
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 1, 2023 •
edited
Loading

A quick look at this, 2 weeks in, I believe we solved this issue recently, and we just start to get data as there is a lag to deploy the docs, and have users using the search to gather analytics:

Screenshot 2023-07-01 at 14 01 34

I will check again in 2 weeks to see how it looks.

@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Jul 1, 2023
@oliviertassinari
Copy link
Member

I will check again in 2 weeks to see how it looks.

It seems all good, we are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @mui-bot @oliviertassinari @alexfauquette