[RadioButton] add callback signatures to docs; improve other props #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * `RadioButtonGroup`. | ||
| * | ||
| * @param {object} event `change` event targeting the element. | ||
| * @param {string} value The element's `value`. | ||
| */ | ||
| onCheck: React.PropTypes.func, |
There was a problem hiding this comment.
Would RadioButton ever be used outside of the RadioButtonGroup, or could this just be @ignored?
There was a problem hiding this comment.
I can't think of any use for it outside of a RadioButtonGroup; if checked was a public prop on RadioButton it could be used independently, but since it isn't @ignore seems better.
There was a problem hiding this comment.
Feel free to change it then. You could leave (update) the description etc for internal reference.
37 tasks
|
Thanks @theosherry 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, another one for #3096. I noticed that the
onCheckcallback ofRadioButtonelements wasn't being called when they were part of aRadioButtonGroup, so I added a bit of warning for this behaviour.