Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fail the CI when new unexpected files are created #38039

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 19, 2023

This is a follow-up on #37813 (comment).

  1. First the most important: I could break yarn docs:api without knowing it. The CI should now fail, see the first commit. I have copied git add -A && git diff --exit-code --staged from an existing test we have.
  2. Second, the fix of yarn docs:api, see the second commit.

@mui-bot
Copy link

mui-bot commented Jul 19, 2023

Netlify deploy preview

https://deploy-preview-38039--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eac903f

@zannager zannager requested a review from mnajdova July 19, 2023 12:35
@oliviertassinari oliviertassinari changed the title [test] Also fail the CI when new unexpected files are created [test] Fail the CI when new unexpected files are created Jul 19, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 20, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 21, 2023
@oliviertassinari oliviertassinari merged commit a5d05e2 into mui:master Jul 24, 2023
@oliviertassinari oliviertassinari deleted the fix-regression branch July 24, 2023 22:51
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants