Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Reapply #3492 with checkbox cell highlight. Fix #1783, fix #3714 #3812

Closed
wants to merge 1 commit into from
Closed

[Table] Reapply #3492 with checkbox cell highlight. Fix #1783, fix #3714 #3812

wants to merge 1 commit into from

Conversation

ccomb
Copy link
Contributor

@ccomb ccomb commented Mar 25, 2016

Reapply #3492 to fix #1783 with additional fix for regression #3714
(Hoping it will allow to reapply #3505 )

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@mbrookes
Copy link
Member

Please follow my guidance in #3492.

@mbrookes mbrookes added bug 🐛 Something doesn't work PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 26, 2016
This was referenced May 3, 2016
Closed
Closed
@nathanmarks
Copy link
Member

Closing due to lack of movement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccomb @mbrookes @nathanmarks