Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][MenuButton] Fix disable of MenuButton #38342

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 6, 2023

This PR makes sure MenuButton is disabled when disabled prop is set to true

before: https://codesandbox.io/s/loving-leftpad-nrxpvc?file=/Demo.js

after: https://codesandbox.io/s/nostalgic-pond-whrs7p

@sai6855 sai6855 added bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy labels Aug 6, 2023
@mui-bot
Copy link

mui-bot commented Aug 6, 2023

Netlify deploy preview

https://deploy-preview-38342--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c89a025

@mnajdova mnajdova merged commit 7d7ac0e into mui:master Aug 7, 2023
@sai6855 sai6855 deleted the menu-disable branch August 7, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants