Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup] Determine first, last and middle buttons to support different elements with correct styling #38520

Merged
merged 22 commits into from
Sep 8, 2023
Merged

[ButtonGroup] Determine first, last and middle buttons to support different elements with correct styling #38520

merged 22 commits into from
Sep 8, 2023

Commits on Aug 17, 2023

  1. add regression test

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    393f3a0 View commit details
    Browse the repository at this point in the history

  2. [ButtonGroup] Determine first and last buttons

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9dcb327 View commit details
    Browse the repository at this point in the history

  3. add middle button class

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    01103cc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into determine-first-last-buttons-in-button-group

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b9f6c7b View commit details
    Browse the repository at this point in the history

  5. update docs

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    62af815 View commit details
    Browse the repository at this point in the history

  6. fix style description

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f4bb2b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. use data- attributes instead of class names

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a7f1084 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. handle case for only a single button and if not within a button group… 

    … context
    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    34f37ff View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. reorganize Button group styles

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8a1c416 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into determine-first-last-buttons-in-button-group

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    367ce5a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. rename interface

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5c7de19 View commit details
    Browse the repository at this point in the history

  2. add data attributes directly

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5e38727 View commit details
    Browse the repository at this point in the history

  3. remove redundant onlyChild

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    26650cf View commit details
    Browse the repository at this point in the history

  4. rename one to single

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d7665e4 View commit details
    Browse the repository at this point in the history

  5. rename variables

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    dc7f138 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. use "is" prefix in first and last button variable names

    @ZeeshanTamboli
    ZeeshanTamboli committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    77f651d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. use classnames instead of data attributes

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1939e1b View commit details
    Browse the repository at this point in the history

  2. add unit tests

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    30b5ba8 View commit details
    Browse the repository at this point in the history

  3. move button position classes logic to button group component

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    69b97f6 View commit details
    Browse the repository at this point in the history

  4. rename method name and type

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9f3dd29 View commit details
    Browse the repository at this point in the history

  5. prettier

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e76692f View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'master' into determine-first-last-buttons-in-button-group

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c5f8b76 View commit details
    Browse the repository at this point in the history