Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve ref type definition #38903

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 10, 2023

A continuation of #38762.

Also, better to use https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#non-null-assertion-operator-postfix- to remove null from the type than to reassign the whole type.

@oliviertassinari oliviertassinari added typescript core Infrastructure work going on behind the scenes labels Sep 10, 2023
@mui-bot
Copy link

mui-bot commented Sep 10, 2023

Netlify deploy preview

https://deploy-preview-38903--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1be8e5f

@oliviertassinari oliviertassinari merged commit 4f5acaa into mui:master Sep 24, 2023
@oliviertassinari oliviertassinari deleted the fix-types-ref branch September 24, 2023 15:04
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants