[core] Replace a useCallback by useRef in useEventCallback

[romgrk]

Minor touchup, useRef is leaner than useCallback.

[mui-bot]

Netlify deploy preview

https://deploy-preview-39078--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 5a2490c

[mnajdova]

LGTM cc @michaldudak

[oliviertassinari]

This makes me think of this thread: mui/toolpad#2671 (comment) I had with @Janpot. We initially copied https://github.com/reactjs/rfcs/blob/useevent/text/0000-useevent.md#internal-implementation

[romgrk]

Tbh I feel our useEventCallback is a bit weird. In the React RFC you linked, the ref is initialized as null under the rationale that they want it to throw if it's called during render, for reasons that make sense from a correctness/DX POV (even if a bit pedantic, but I get they need it in react core). But in our implementation we both initialize the ref with the callback directly AND we update it in the useLayoutEffect. So we both don't get the benefit of throw-during-render, and we pay the cost of adding an effect.

[Janpot]

For reference, this was our implementation: https://github.com/mui/mui-toolpad/blob/6cd4f8f289472d75811a39cc6ef567dc2024e85f/packages/toolpad-app/src/utils/useEvent.ts