[material-ui][Autocomplete] Unselect options when mouse leaves. #39462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39462--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: autocomplete
What is the problem: - Currently, when your mouse leaves the Autocomplete Popover, the last hovered item is selected. What are we fixing: - We are adding a minor onMouseLeave event to each option. When you leave the option, it will remove any selection by selecting the -1 index. - We also added a prop: keepSelectedOnLeave if people still want this functionality. But we default to not having this functionality. I'm open to preserving backward compatibility, but it seems to make sense from reading the GitHub issues that it would be preferred as not default behavior. Note: It might be better performance wise, to add a toplevel mousemove and mouseleave event instead of a mousemove/mouseleave event per option. That way we wouldn't have to install so many event listeners.
joeheyming
force-pushed
the
jheyming/blur-on-option-leave
branch
from
d1ad5b5
to
37ab2f5
Compare
|
I'm doing this for #hacktoberfest |
This doesn't work well when you try to scroll through the list - the scroll position is continuously reset.
We can't introduce breaking changes between major versions. The solution must be backward-compatible. |
michaldudak
added
PR: needs revision
|
Since this PR is inactive and hasn't addressed the above comment, I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem 🤔
What are we fixing 🔧
We are adding a minor onMouseLeave event to each option. When you leave the option, it will remove any selection by selecting the -1 index.
We also added a prop: keepSelectedOnLeave if people still want this functionality. But we default to not having this functionality.
I'm open to preserving backward compatibility, but it makes sense from reading the GitHub issues that it would be preferred as not default behavior.
Note: It might be better, performance-wise, to add a top-level mousemove and mouseleave event instead of a mousemove/mouseleave event per option. That way, we wouldn't have to install so many event listeners.
Screen.Recording.2023-10-15.at.11.21.20.AM.mov