-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system][material-ui] Move useMediaQuery to system #39463
[system][material-ui] Move useMediaQuery to system #39463
Conversation
Netlify deploy previewhttps://deploy-preview-39463--material-ui.netlify.app/ @material-ui/system: parsed: +1.40% , gzip: +1.41% Bundle size reportDetails of bundle changes (Toolpad) |
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: justintoman <justintoman@gmail.com>
I don't understand why the browser tests for joy began failing. This feels like an import issue, and it seems like it's only happening in bundled environments. I've tried a number of things
I didn't commit any of that because it didn't solve anything. Kinda stumped here 😅 would appreciate if someone could give me some help. 🙏 Sorry, thought this would be an easier lift. I'll keep trying but I don't feel like I have a clear idea of how to approach this. |
I moved the test back to |
Looks like it should be good to go, unless any of those changes I mentioned here for the bundling/test/webpack stuff need to go in. |
Watching to see when this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the PR!
This has been approved for a while... anything holding it up? Willing to update whatever is necessary! |
I will merge after the CIs are green. Thanks for the PR and very sorry for the delay. |
@michaldudak @Janpot Need your help, the CI error seems unrelated to the change. Can you guess what would be the root cause? |
Looks like we're low on memory during typechecking. Try reducing concurrency in the |
I think I ran into this as well last week and increased available memory for this script. edit: @siriwatknp That PR got merged, you may want to try and rebase |
…-use-media-query-to-system
This needs to be added to the Joy-UI documentation. With Material UI, we can import I hope this issue can be addressed. #41402 It would also be better if Joy-UI moved away from |
useMediaQuery
to@mui/system
@mui/material
to prevent breaking changesuseMediaQuery
hook #35037