-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Replace all '@mui/utils' imports #39878
Conversation
Netlify deploy previewhttps://deploy-preview-39878--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #614978 finishes. |
I am creating #39882 to fix the errors for exports not being modules. |
material-ui
package@@ -1,4 +1,4 @@ | |||
import { unstable_generateUtilityClasses as generateUtilityClasses } from '@mui/utils'; | |||
import generateUtilityClasses from '@mui/utils/generateUtilityClasses'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With generateUtilityClasses
, we could import the local Material UI version (similarly to generateUtilityClass). It would allow us to customize the class name pattern.
import generateUtilityClasses from '@mui/utils/generateUtilityClasses'; | |
import generateUtilityClasses from '../generateUtilityClasses'; |
@MonstraG could you please rebase on top of the latest master and check the failing tests? |
I'll open a new pull request then. It seems that somebody already merged #40254, Which reverses this decision:
so I'm not doing it |
This is an attempt at doing #35840 with a limited scope:
All of these changes were done automatically with:
node.js code
If this is a replacement that we are looking for, I can try running this on all packages, and start adapting it to other imports (like system, base, but they would require more work)