-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base-ui] Fix form submission Select demo #40014
[docs][base-ui] Fix form submission Select demo #40014
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! The unconditional rendering of the hidden input was introduced at some point, but apparently the docs were not updated.
@michaldudak, I noticed that the "If the name is provided, the component will render a hidden input element that can be submitted to a server." Should we consider removing it? Also, |
Yes, it's no longer true. Let's remove it. |
@michaldudak Done. |
The form submission demo appears incorrect to me. It was added in #34638, but it lacks a
form
HTML element. Additionally, the statement "When thename
prop is set, the Select will render a hidden input with the selected value." is incorrect because the hidden input is always rendered.I've also removed the sentence in the documentation that reads:
and retained one demo with a form and a submit button.
Preview - https://deploy-preview-40014--material-ui.netlify.app/base-ui/react-select/#form-submission.