Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][NumberInput] Remove inputId and inputRef types from NumberInput component #40425

Merged
merged 12 commits into from
Jan 10, 2024
Merged

[base-ui][NumberInput] Remove inputId and inputRef types from NumberInput component #40425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d388cb3
trigger
sai6855 Dec 24, 2023
7d19434
Merge branch 'master' of https://github.com/sai6855/material-ui
sai6855 Dec 25, 2023
2bbeffc
Merge branch 'master' of https://github.com/sai6855/material-ui
sai6855 Dec 28, 2023
c8dec0f
Merge branch 'master' of https://github.com/sai6855/material-ui
sai6855 Dec 30, 2023
c08f4c7
Merge branch 'master' of https://github.com/sai6855/material-ui
sai6855 Jan 3, 2024
576ed20
Merge branch 'master' of https://github.com/sai6855/material-ui
sai6855 Jan 4, 2024
21f6a1c
remove inputId prop in NumberInputOwnProps
sai6855 Jan 4, 2024
bdd6037
Fix formatting in NumberInputOwnProps type definition
sai6855 Jan 4, 2024
2182f3b
trigger
sai6855 Jan 4, 2024
1fa90cd
apply changes from code review
sai6855 Jan 10, 2024
c7020c8
Merge branch 'master' into number-input-inputid
sai6855 Jan 10, 2024
8ea34d2
Remove inputRef from type
sai6855 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/mui-base/src/Unstable_NumberInput/NumberInput.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import * as React from 'react';
import { Unstable_NumberInput as NumberInput } from '@mui/base/Unstable_NumberInput';

/* @ts-expect-error - inputId shouldn't be available on NumberInput */
<NumberInput inputId="" />;

/* @ts-expect-error - inputRef shouldn't be available on NumberInput */
<NumberInput inputRef={{}} />;
5 changes: 4 additions & 1 deletion packages/mui-base/src/Unstable_NumberInput/NumberInput.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ export interface NumberInputRootSlotPropsOverrides {}
export interface NumberInputInputSlotPropsOverrides {}
export interface NumberInputStepperButtonSlotPropsOverrides {}

export type NumberInputOwnProps = Omit<UseNumberInputParameters, 'error'> & {
export type NumberInputOwnProps = Omit<
UseNumberInputParameters,
'error' | 'inputId' | 'inputRef'
> & {
/**
* Trailing adornment for this input.
*/
Expand Down