-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system][zero] Move zero runtime related packages #40426
Conversation
Netlify deploy previewhttps://deploy-preview-40426--material-ui.netlify.app/ Bundle size report |
@brijeshb42 I don't have the bandwidth to go through all the code. I'll try to go through it diagonally. I assume the business logic has been reviewed on its original repo? Did you have to change much compared to your original setup? Anything you had to hack around or noticed any rough edges? |
3307c23
to
e5ee3bb
Compare
cf6f251
to
7fb6c54
Compare
Will we keep it that way or migrate? |
The plan is to keep it that way in the short term to focus on the actual development and migrate away in the long term. |
@mnajdova This PR is now ready for review after all the build related problems are solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the initial testing, everything seems to work 🎉 I left two thins to be checked before merging.
After the merge, we need to cleanup the example app and provide structure for how we are going to validate that the migrated components work.
from the separate repo
and updated new paths for theme token generation. Also added Slider example to next app
directly in the library
zero-runtime styled component
This helps running the commands in correct order as per dependencies
from the separate repo