[system] Fix build size with material-ui-nextjs #40436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40203
The root cause comes from the import of
next/document
in the same file asAppCacheProvider
which includes unnecessary javascript to the output of_app.js
.Fixed by splitting the files into document and app files.
Before:
After:
Testing
clone the material-ui-nextjs-pages-router-ts example
Run
yarn && yarn build
to see the issue (similar to Before image)Open
package.json
and replace the@mui/material-nextjs
version withhttps://pkg.csb.dev/mui/material-ui/commit/2d5cbbca/@mui/material
.Delete the
.next
folder and runyarn && yarn build
again (the bundle size should be green)