[code-infra] Don't require noreferrer on target link #40447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
commented
Jan 6, 2024
| @@ -79,7 +79,7 @@ export default function DiamondSponsors() { | |||
| data-ga-event-action="docs-premium" | |||
| data-ga-event-label="octopus.com" | |||
| href="https://octopus.com/?utm_source=materialui&utm_medium=referral" | |||
| rel="noopener noreferrer sponsored" | |||
There was a problem hiding this comment.
On a sponsor link, it cripples their analytics 🙈
Netlify deploy previewBundle size report |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
oliviertassinari
added a commit
to mui/mui-x
that referenced
this pull request
Mar 10, 2024
See mui/material-ui#40447 for why.
oliviertassinari
added a commit
that referenced
this pull request
Mar 10, 2024
I missed those from #40447.
This was referenced May 8, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
See mui/material-ui#40447 for why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noreferreris only required for IE 11 and lower, which we don't support anymore, so the eslint config needs to change.Then, the question is when do we want to use noreferrer? By default it lets the site we link know that we link them, it sounds like a positive thing overall.
For sponsor links, we definitely don't want to have noreferrer.
I think we must keep
noreferreron the templates / examples, as we don't want developers using the default config of eslint to have a warning when they copy & paste our content. We can wait for eslint to change their default, I reported the problem at jsx-eslint/eslint-plugin-react#3672.