[base-ui] Fix replace array API with ReadonlyArray type #40760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KumarNitin19
commented
Jan 23, 2024
•
KumarNitin19
commented
- I have followed (at least) the PR section of the contributing guide.
- [typescript] Replace Array API with ReadonlyArray #40750 fixed in this PR.
Netlify deploy previewhttps://deploy-preview-40760--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #641815 finishes. |
michaldudak
reviewed
Jan 24, 2024
| @@ -136,8 +136,8 @@ function focusThumb({ | |||
| } | |||
|
|
|||
| function areValuesEqual( | |||
| newValue: number | Array<number>, | |||
| oldValue: number | Array<number>, | |||
| newValue: number | Readonly<number> | number[], | |||
There was a problem hiding this comment.
Readonly<number> doesn't make much sense. The point of the issue was to convert arrays into ReadonlyArrays throughout the codebase.
Suggested change
| newValue: number | Readonly<number> | number[], | |
| newValue: number | ReadonlyArray<number>, |
There was a problem hiding this comment.
@michaldudak I have changed ReadOnly with ReadOnlyArray, please check.
Thanks!
danilo-leal
changed the title
|
Please see #40754 (comment) |
|
Closing in favor of #40754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.