[docs-infra] Fix display when the default props is undefined #41114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-41114--material-ui.netlify.app/ Bundle size report |
danilo-leal
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I will say, though, that I'm not particularly bothered by the "regression". I think a blank space bothers me more than an empty code block that looks like a dash, which fills up the space somehow instead of leaving it there empty. It could be just personal preference.
oliviertassinari
added
enhancement
|
Deal 😃 👍 |
oliviertassinari
force-pushed
the
docs-infra-fix-prop-defaults
branch
from
de9b76d
to
f892e93
Compare
6 tasks
oliviertassinari
changed the title
alexfauquette
approved these changes
Feb 16, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been visible for a while, e.g. in #39689 (review). It feels like there is a bug in the way the data is displayed, it doesn't feel like I can 100% trust what's shown on the API page. I saw this in mui/mui-x#11996.
Before https://deploy-preview-41113--material-ui.netlify.app/material-ui/api/app-bar/#props
After https://deploy-preview-41114--material-ui.netlify.app/material-ui/api/app-bar/#props
