Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Inform about deprecated TablePagination SelectProps usage #41186

Merged
merged 4 commits into from
Feb 19, 2024
Merged

[material-ui][docs] Inform about deprecated TablePagination SelectProps usage #41186

merged 4 commits into from
Feb 19, 2024

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Feb 19, 2024 •
edited
Loading

Closes #41062

Description

Replace deprecated SelectProps property on CustomPaginationActions with slotProps

Refs

Loom Video

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @jasmyneokudo
fix: change TablePagination SelectProps to slotProps
b2952e6 
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Feb 19, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41186--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 106eab7

@danilo-leal danilo-leal changed the title MUI-41062 - [docs] Deprecated TablePagination SelectProps usage [material-ui][docs] Inform about deprecated TablePagination SelectProps usage Feb 19, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: table This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 19, 2024
gitstart and others added 3 commits February 19, 2024 17:00
@gitstart
Merge commit '7c61280c24ef7edf5536613d125efdf2484ff995' of https://gi…
8616cdf 
…thub.com/gitstart/material-ui into MUI-41062
@gitstart @jasmyneokudo
fix: prettier error
3b7f83d 
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
@gitstart @jasmyneokudo
fix: update typescript docs
106eab7 
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review February 19, 2024 17:44
@gitstart
Copy link
Contributor Author

@DiegoAndai This PR is ready for review

DiegoAndai
DiegoAndai approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitstart!

@DiegoAndai DiegoAndai merged commit 70b3d36 into mui:master Feb 19, 2024
19 checks passed
@DiegoAndai DiegoAndai mentioned this pull request Feb 19, 2024
Closed
1 task
This was referenced May 24, 2024
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jun 5, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
@Crushoverride007 Crushoverride007 mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Deprecated TablePagination SelectProps usage
4 participants
@gitstart @mui-bot @DiegoAndai @danilo-leal