-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Transitions] External ownerState is incorrectly forwarded to inner components #41187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-41187--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
MUI-40653 - [material-ui][Transitions] External ownerState is incorrectly forwarded to inner components
[material-ui][Transitions] External ownerState is incorrectly forwarded to inner components
Feb 19, 2024
danilo-leal
added
component: transitions
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
labels
Feb 19, 2024
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@DiegoAndai This PR is ready for review |
DiegoAndai
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gitstart
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: transitions
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix forwarded
ownerState
from Transition component overriding component own'sownerState
https://www.loom.com/share/96131abf63ba48878bf3e8d02856cce3
closes #40653
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.