Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Transitions] External ownerState is incorrectly forwarded to inner components #41187

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

gitstart
Copy link
Contributor

Description

Fix forwarded ownerState from Transition component overriding component own's ownerState

https://www.loom.com/share/96131abf63ba48878bf3e8d02856cce3

closes #40653


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Feb 19, 2024

Netlify deploy preview

https://deploy-preview-41187--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e3cfd04

@danilo-leal danilo-leal changed the title MUI-40653 - [material-ui][Transitions] External ownerState is incorrectly forwarded to inner components [material-ui][Transitions] External ownerState is incorrectly forwarded to inner components Feb 19, 2024
@danilo-leal danilo-leal added component: transitions This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 19, 2024
gitstart and others added 2 commits February 19, 2024 17:04
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review February 19, 2024 17:23
@gitstart
Copy link
Contributor Author

@DiegoAndai This PR is ready for review

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gitstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: transitions This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Transitions] External ownerState is incorrectly forwarded to inner components
4 participants