[material-ui] Refine the Sign-in and Sign-up templates #41192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Netlify deploy previewhttps://deploy-preview-41192--material-ui.netlify.app/ Bundle size report |
10 tasks
github-actions
bot
removed
the
PR: out-of-date
danilo-leal
reviewed
Mar 25, 2024
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/getSignInSideTheme.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/public/static/images/templates/templates-images/dark-background.png
Outdated
Show resolved
Hide resolved
danilo-leal
reviewed
Mar 25, 2024
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
danilo-leal
reviewed
Mar 25, 2024
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in/SignIn.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
danilo-leal
reviewed
Mar 26, 2024
docs/data/material/getting-started/templates/sign-in-side/ToggleColorMode.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/SignInSide.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/CustomIcons.js
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/CustomIcons.js
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/Content.tsx
Outdated
Show resolved
Hide resolved
danilo-leal
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Looking great! Thanks for bearing with me on all the reviews 🤝 Last "major" request is to add labels to all the input fields so they're accessible. We can't rely on just the placeholder. This will naturally increase the height of all of the cards, so keep an eye out for mobile scrolling (everything should be fine, though).
docs/data/material/getting-started/templates/sign-in-side/SignInSide.tsx
Outdated
Show resolved
Hide resolved
danilo-leal
approved these changes
Mar 27, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37555
This PR is for refining the Sign-in and Sign-out templates, to be aligned with the new landing page theme.
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-up/
👉 https://deploy-preview-41192--material-ui.netlify.app/material-ui/getting-started/templates/sign-in-side/