[Slider][material-ui] Convert to support CSS extraction #41201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
component: slider
mnajdova
force-pushed
the
slider/convert-to-zero-runtime
branch
from
ed00a4e
to
a28f3f0
Compare
Netlify deploy previewhttps://deploy-preview-41201--material-ui.netlify.app/ @material-ui/core: parsed: +0.19% , gzip: +0.14% Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
mnajdova
commented
Mar 8, 2024
| export const rootShouldForwardProp = (prop) => shouldForwardProp(prop) && prop !== 'classes'; | ||
|
|
||
| export const slotShouldForwardProp = shouldForwardProp; | ||
| export { default as slotShouldForwardProp } from './slotShouldForwardProp'; |
There was a problem hiding this comment.
I had to extract these to separate files, otherwise we were ending up with importing from the styled.js, which resulted with the error:
/Users/marijanajdova/workspace/mui/apps/node_modules/.pnpm/@wyw-in-js+transform@0.5.0_typescript@5.3.3/node_modules/@wyw-in-js/transform/lib/module.js:223
throw new EvalError(`${e.message} in${this.callstack.join('\n| ')}\n`);
^
EvalError: _systemDefaultTheme is not defined in/Users/marijanajdova/workspace/mui/packages/mui-system/build/createStyled.js
| /Users/marijanajdova/workspace/mui/packages/mui-material/build/styles/slotShouldForwardProp.js
| /Users/marijanajdova/workspace/mui/packages/mui-material/build/Slider/Slider.js
Once the PR is merged, I will update all imports we have in Material UI, so that we don't have to add additional check in the migration steps.
There was a problem hiding this comment.
I found a different fix in https://github.com/mui/material-ui/pull/41378/files#diff-23f194f4651836b6ce3d86b341074002f86e1bfcf3958c665fdf25a18aecfafb but I think we should have both.
siriwatknp
reviewed
Mar 13, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-41201--material-ui.netlify.app/material-ui/react-slider/