Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][FormControl] Export FormControlOwnerState type from index #41287

Merged
merged 4 commits into from
Mar 5, 2024
Merged

[base-ui][FormControl] Export FormControlOwnerState type from index #41287

merged 4 commits into from
Mar 5, 2024

Conversation

michaeldfoley
Copy link
Contributor

@michaeldfoley michaeldfoley commented Feb 27, 2024 •
edited
Loading

Closes #41286

@michaeldfoley
Export FormControlOwnerState type from index
3ce09b2 
Signed-off-by: Michael Foley <michaeldfoley@gmail.com>
@mui-bot
Copy link

mui-bot commented Feb 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41287--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 135ca8d

@zannager zannager added the component: FormControl The React component label Feb 27, 2024
@zannager zannager requested a review from mj12albert February 27, 2024 12:39
@danilo-leal danilo-leal added the package: base-ui Specific to @mui/base label Feb 29, 2024
@danilo-leal danilo-leal changed the title Export FormControlOwnerState type from index [base-ui] Export FormControlOwnerState type from index Feb 29, 2024
@danilo-leal danilo-leal changed the title [base-ui] Export FormControlOwnerState type from index [base-ui][FormControl] Export FormControlOwnerState type from index Feb 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Mar 5, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeldfoley Thanks for the PR. I've updated it to export all types from the .types.ts file, which is the preferred approach.

@ZeeshanTamboli ZeeshanTamboli merged commit 9f2ee3c into mui:master Mar 5, 2024
23 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@michaeldfoley @ZeeshanTamboli @mnajdova
[base-ui][FormControl] Export FormControlOwnerState type from index (…
b919a5d 
…mui#41287)

Signed-off-by: Michael Foley <michaeldfoley@gmail.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@amylank22 amylank22 mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
@mx1613 mx1613 mentioned this pull request May 21, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request May 22, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: FormControl The React component package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[base-ui][FormControl] Export FormControlOwnerState type from FormControl
5 participants
@michaeldfoley @mui-bot @ZeeshanTamboli @danilo-leal @zannager